Support pagination with Solr Result Grouping #145
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using [result grouping](https://cwiki.apache.org/confluence/display/solr/Result+Grouping), we don't get a simple number of documents matched. Instead, related documents are collapsed into groups and the groups are what we (probably) want to paginate. This is a bit whacky as it is technically possible to specify different grouping criteria. In that case, we'd get multiple lists of groups back. This change only looks at the first grouping applied as I don't see how we could make sense of the multi-group case.
|
/cc @dword123 |
|
Thank you for your contribution. Could you add a test case for result grouping please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using result grouping, we don't get a simple number of documents matched. Instead, related documents are collapsed into groups and the groups are what we (probably) want to paginate.
This is a bit whacky as it is technically possible to specify different grouping criteria. In that case, we'd get multiple lists of groups back.
This change only looks at the first grouping applied as I don't see how we could make sense of the multi-group case.