Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding merging functionality #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nine-inch-rails
Copy link

With regards to this: #34

I've made it so that you can pass a flag to start generating a report and merge it with the existing json (rspec only, though extending the functionality shouldn't be so tough).
The flag is: KNAPSACK_MERGE_REPORT=true and is set with the KNAPSACK_GENERATE_REPORT flag

This addition does two things:
If a new spec(s) is added, its/their runtime is added to the existing json
If it's run against the suite, the existing times will be overwritten with the new ones via hash merge, 'updating' them

@wscourge
Copy link

@ArturT @shadre is this going to get merged? Do you guys still maintain this repo, or should I fork and use my own?

@ArturT
Copy link
Member

ArturT commented Dec 16, 2022

@wscourge At this moment, we abstain from the decision to introduce new features.

I hope in 2023, we will clarify the high-level plans so that we can put more focus on delivering value to users. We will better understand how the knapsack gem fits into that.

@wscourge
Copy link

OK, looking forward to it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants