Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps #60

Merged
merged 2 commits into from Sep 19, 2023
Merged

Upgrade deps #60

merged 2 commits into from Sep 19, 2023

Conversation

3v0k4
Copy link
Contributor

@3v0k4 3v0k4 commented Sep 14, 2023

First of all, don't panic! The diff is 99% in the locks that got updated.

This will be a major bump of core, jest, and cypress.

You can review the flags used in tsconfig.json in the official docs. I also used the node 18 base as an inspiration since we are already saying in the readme we require node 18, which is the current active lts.

We discussed in the past a problem with axios-retry not working with axios. But that was only limited to axios 19.0. I tested that fallback mode actually works with the latest axios and axios-retry.

I didn't spot any problematic changes in the dependencies bumped.

I'm leaving the peerDependencies in jest and cypress as they are because I didn't change how we use those, but I believe we should require the same major as we use in devDependencies for jest and cypress.

This also removes changesets because it was forcing on us a release workflow that did not work.

Bumps

@3v0k4 3v0k4 marked this pull request as ready for review September 19, 2023 07:26
@3v0k4 3v0k4 merged commit b15746a into main Sep 19, 2023
1 check passed
@3v0k4 3v0k4 deleted the upgrade-deps branch September 19, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants