Added test for non super user token #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#77 Created a pull request for this issue. I'll be glad to help manage this repo. |
Kludex
reviewed
Apr 3, 2023
users/tests/conftest.py
Outdated
Comment on lines
61
to
71
| @pytest.fixture() | ||
| async def create_non_superuser(session: AsyncSession) -> Dict[str, str]: | ||
| email = "test_user@test.com" | ||
| password = "Ksd8nASD1_Hjns!P" | ||
| hashed_password = get_password_hash(password) | ||
| result = await session.execute(select(User).where(User.email == email)) | ||
| user: Optional[User] = result.scalars().first() | ||
| if user is None: | ||
| session.add(User(email=email, hashed_password=hashed_password, is_superuser=False)) | ||
| await session.commit() | ||
| return {"email": email, "password": password} |
There was a problem hiding this comment.
Can this be a scope="session" instead?
|
It looks like the pipeline is not running for PRs? 🤔 |
|
I can take a look at the pipeline |
|
Any reason for closing this? 🤔 |
|
I was eating dinner and working at the same time :), accidentally pushed some unwanted changes, and tried to revert using 'git reset' and that closed this PR. Kindy reopen it :) |
|
I'm not able to reopen from here. 😅 |
|
Sorry about this, I've reopened it. |
|
There are no changes here 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created the test for a non-superuser token, and I've added a fixture that adds a test user and one that gets the user's bearer token.