Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump to ITK v5.3rc04 #192

Merged
merged 3 commits into from Apr 14, 2022
Merged

ENH: Bump to ITK v5.3rc04 #192

merged 3 commits into from Apr 14, 2022

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Apr 7, 2022

Bump to most recent ITK version. May require bumping dependencies first.

@tbirdso tbirdso requested a review from dzenanz April 7, 2022 19:50
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand impatience, but I advise not to spend time trying to update CIs prematurely.

.github/workflows/build-test-package.yml Outdated Show resolved Hide resolved
@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 8, 2022

@dzenanz

I understand impatience, but I advise not to spend time trying to update CIs prematurely.

My apologies for not clearly stating the PR intention. @thewtex and I spoke after the hackathon today on next steps for external modules with v5.3rc04, my understanding of the current goal is to ensure that external modules build with the ITK v5.3rc04 wheels before C++ release notes are published.

My initial attempt to upgrade ITKVkFFTBackend failed, apparently due to a pathing issue. My first thought was to attempt a similar bump on another external module to check whether this is an issue with ITKPythonPackage or with the ITKVkFFTBackend module.

I now realize that ITKUltrasound is not the best module for comparison because it depends on several other external modules. I would like to focus efforts on bumping ITKSplitComponents to build and package with v5.3rc04 wheels because its build structure is much less complicated.

Roadmap:

  • Investigate Python CI failures in ITKSplitComponents with v5.3rc04
  • Possibly make changes to ITKPythonPackage / rebuild wheels if necessary
  • Bump ITKSplitComponents and other external modules (ITKVkFFTBackend, maybe ITKUltrasound and its remaining dependencies)
  • Publish release notes for ITK v5.3rc04

@thewtex
Copy link
Member

thewtex commented Apr 8, 2022

To simplify version configuration and make it easier to use other remote modules, in the process of makes these updates to ITKUltrasound, related modules, we should adopt the approach @aylward has taken in ITKTubeTK's configuration in these modules, then add that to the ITKModuleTemplate.

@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 13, 2022

ITK v5.3rc04 build archives are now stable (see https://github.com/insightsoftwareconsortium/itksplitcomponents for example of successful v5.3rc04 package). Pushing this forward as a prerequisite for #182.

@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 13, 2022

Note linter failures are tracked in InsightSoftwareConsortium/ITKSplitComponents#52 and result from a recent git security patch. A fix appears to be forthcoming from Github Actions. For now linter failures should not be considered blocking.

@tbirdso tbirdso marked this pull request as ready for review April 13, 2022 21:24
@tbirdso tbirdso requested a review from thewtex April 14, 2022 18:44
@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 14, 2022

@dzenanz @thewtex Ping for review

@tbirdso
Copy link
Contributor Author

tbirdso commented Apr 14, 2022

Note linter issue has been resolved by Github Actions

@tbirdso tbirdso merged commit 8cacf76 into KitwareMedical:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants