New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Bump to ITK v5.3rc04 #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand impatience, but I advise not to spend time trying to update CIs prematurely.
My apologies for not clearly stating the PR intention. @thewtex and I spoke after the hackathon today on next steps for external modules with v5.3rc04, my understanding of the current goal is to ensure that external modules build with the ITK v5.3rc04 wheels before C++ release notes are published. My initial attempt to upgrade ITKVkFFTBackend failed, apparently due to a pathing issue. My first thought was to attempt a similar bump on another external module to check whether this is an issue with ITKPythonPackage or with the ITKVkFFTBackend module. I now realize that ITKUltrasound is not the best module for comparison because it depends on several other external modules. I would like to focus efforts on bumping ITKSplitComponents to build and package with v5.3rc04 wheels because its build structure is much less complicated. Roadmap:
|
To simplify version configuration and make it easier to use other remote modules, in the process of makes these updates to ITKUltrasound, related modules, we should adopt the approach @aylward has taken in ITKTubeTK's configuration in these modules, then add that to the ITKModuleTemplate. |
ITK v5.3rc04 build archives are now stable (see https://github.com/insightsoftwareconsortium/itksplitcomponents for example of successful v5.3rc04 package). Pushing this forward as a prerequisite for #182. |
Note linter failures are tracked in InsightSoftwareConsortium/ITKSplitComponents#52 and result from a recent git security patch. A fix appears to be forthcoming from Github Actions. For now linter failures should not be considered blocking. |
Note linter issue has been resolved by Github Actions |
Bump to most recent ITK version. May require bumping dependencies first.