Load language data in v5.6.2 and v5.7.0 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of sphinx (starting with [this commit](sphinx-doc/sphinx@f5289bb)) no longer automatically load the `language_data.js` file. This would cause the `sphinx_rtd_theme` to have an error when attempting to search that stated `Uncaught ReferenceError: Stemmer is not defined`. The `Stemmer` is a class normally defined in the `language_data.js` file. Newer versions of `sphinx_rtd_theme` load the `language_data.js` file in manually, starting from [this PR](readthedocs/sphinx_rtd_theme#1021). Load the language data in via a similar setup so that the search works for v5.6.2 and v5.7.0. The latest `language_data.js` file was used. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
vicentebolea
approved these changes
Mar 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
Load language data in v5.6.2 and v5.7.0
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
Load language data in v5.6.2 and v5.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of sphinx (starting with this commit)
no longer automatically load the
language_data.jsfile. This wouldcause the
sphinx_rtd_themeto have an error when attempting to searchthat stated
Uncaught ReferenceError: Stemmer is not defined. TheStemmeris a class normally defined in thelanguage_data.jsfile.Newer versions of
sphinx_rtd_themeload thelanguage_data.jsfilein manually, starting from this PR.
Load the language data in via a similar setup so that the search
works for v5.6.2 and v5.7.0.
The latest
language_data.jsfile was used.@vicentebolea