FOCUSED: Fix low-contrast of line and dot in number-line component #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.31 kB (+0.28%) Total Size: 842 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1281 +/- ##
==========================================
+ Coverage 69.18% 71.51% +2.32%
==========================================
Files 476 486 +10
Lines 101772 102648 +876
Branches 7226 11751 +4525
==========================================
+ Hits 70415 73404 +2989
+ Misses 31178 29244 -1934
+ Partials 179 0 -179
... and 165 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Myranae
commented
May 16, 2024
| @@ -472,25 +472,25 @@ class NumberLine extends React.Component<Props, State> { | |||
| // it can't be interacted with. | |||
| let fill; | |||
| if (isOpen) { | |||
| fill = KhanColors._BACKGROUND; | |||
| fill = "transparent"; | |||
There was a problem hiding this comment.
This was changed based on a comment in the file defining KhanColors that said it should be made transparent instead of using _BACKGROUND
Myranae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes an issue where the line and point in the number-line widget were not meeting the WCAG standards for color contrast. The contrast should be at least 3:1, which is implemented here using WB color tokens.
Before fix:
After fix:
Issue: LEMS-252
Test plan:
yarn storybook