Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node to v20 #1276

Merged
merged 3 commits into from
May 17, 2024
Merged

Update node to v20 #1276

merged 3 commits into from
May 17, 2024

Conversation

mark-fitzgerald
Copy link
Contributor

@mark-fitzgerald mark-fitzgerald commented May 15, 2024

Update to node 20, and use revised version of changeset action.

@mark-fitzgerald mark-fitzgerald self-assigned this May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

Size Change: 0 B

Total Size: 839 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.5 kB
packages/math-input/dist/es/strings.js 1.73 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 877 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 403 kB
packages/perseus/dist/es/strings.js 3.22 kB
packages/pure-markdown/dist/es/index.js 3.68 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@mark-fitzgerald mark-fitzgerald marked this pull request as ready for review May 15, 2024 23:19
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to package.json, .github/workflows/node-ci.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented May 17, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (38e4b1b) and published it to npm. You
can install it using the tag PR1276.

Example:

yarn add @khanacademy/perseus@PR1276

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1276

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (58d2a52) to head (38e4b1b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   68.93%   70.22%   +1.29%     
==========================================
  Files         477      481       +4     
  Lines      101798   101865      +67     
  Branches     5099    10286    +5187     
==========================================
+ Hits        70170    71534    +1364     
+ Misses      31513    30331    -1182     
+ Partials      115        0     -115     

Impacted file tree graph

see 129 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d2a52...38e4b1b. Read the comment docs.

@mark-fitzgerald mark-fitzgerald merged commit 70e1c0f into main May 17, 2024
13 checks passed
@mark-fitzgerald mark-fitzgerald deleted the update-to-node-20 branch May 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants