Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @changesets/ tooling to latest #1129

Closed
wants to merge 1 commit into from

Conversation

jeremywiebe
Copy link
Collaborator

@jeremywiebe jeremywiebe commented Mar 27, 2024

Summary:

I have been chasing an issue where bumping to a snapshot version sometimes yields and inconsistent set of updates (some snapshotted packages don't reference the snapshot version of a dependency).

For example: In one case I bumped to a snapshot version where perseus, perseus-editor and math-input were all modified. As a result, perseus-editor should be pointing to the snapshot version of math-input. But in the case I encountered, it was pointing to the unchanged, production version.

I am bumping changesets to the latest v2.27.1 (see https://github.com/changesets/changesets/releases?q=cli&expanded=true). I think v2.23.1 fixed the issue (see release notes), specifically:

changesets/changesets#857 7febb59 Thanks @dotansimha! - Fixed an issue with dependency ranges still using pre-existing range modifiers instead of fixed package versions when performing a snapshot release. This ensures that installs of snapshot versions are always reproducible.

Issue: "none"

Test plan:

  1. Make some changes to perseus, perseus-editor, and math-input
  2. Stage all the changes: git add .
  3. Run the command to snapshot version the packages: yarn changeset version --snapshot PR0000
  4. git diff - verify that each package that references a modified dependency is using the snapshot version

@jeremywiebe jeremywiebe self-assigned this Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: 0 B

Total Size: 821 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 80.5 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 265 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/perseus/dist/es/index.js 393 kB
packages/pure-markdown/dist/es/index.js 3.69 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (6cc3171) to head (df99cb0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   67.98%   69.61%   +1.62%     
==========================================
  Files         452      455       +3     
  Lines       98393    98451      +58     
  Branches     6912    10546    +3634     
==========================================
+ Hits        66891    68533    +1642     
+ Misses      31502    29918    -1584     

Impacted file tree graph

see 97 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc3171...df99cb0. Read the comment docs.

@jeremywiebe
Copy link
Collaborator Author

This wasn't actually needed to fix the issue I was chasing! Closing.

@jeremywiebe jeremywiebe deleted the jer/upgrade-changesets branch March 27, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant