Issue checkstyle#12314: Resolve Pitest suppression for misc profile

Kevin222004 · Oct 21, 2022 · ead4fbd · ead4fbd
1 parent ad27aa0
commit ead4fbd
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 19 deletions.
diff --git a/.ci/pitest-suppressions/pitest-misc-suppressions.xml b/.ci/pitest-suppressions/pitest-misc-suppressions.xml
@@ -36,24 +36,6 @@
     <lineContent>log(1, MSG_KEY_WRONG_ENDING, file.getPath());</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>NewlineAtEndOfFileCheck.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck</mutatedClass>
-    <mutatedMethod>setLineSeparator</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/lang/String::toUpperCase with receiver</description>
-    <lineContent>.toUpperCase(Locale.ENGLISH));</lineContent>
-  </mutation>
-
-  <mutation unstable="false">
-    <sourceFile>NewlineAtEndOfFileCheck.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck</mutatedClass>
-    <mutatedMethod>setLineSeparator</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.NakedReceiverMutator</mutator>
-    <description>replaced call to java/lang/String::trim with receiver</description>
-    <lineContent>Enum.valueOf(LineSeparatorOption.class, lineSeparatorParam.trim()</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>OrderedPropertiesCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.OrderedPropertiesCheck</mutatedClass>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java
@@ -212,6 +212,14 @@ public void testWrongSeparatorLength() throws Exception {
         }
     }
 
+    @Test
+    public void testTrimOptionProperty() throws Exception {
+        final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
+        verifyWithInlineConfigParser(
+                getPath("InputNewlineAtEndOfFileTestTrimProperty.java"),
+                expected);
+    }
+
     private static final class ReadZeroRandomAccessFile extends RandomAccessFile {
 
         private ReadZeroRandomAccessFile(String name, String mode)

diff --git a/...m/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java b/...m/puppycrawl/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileCrlf3.java
@@ -1,6 +1,6 @@
 /*
 NewlineAtEndOfFile
-lineSeparator = CRLF
+lineSeparator = crlf
 fileExtensions = (default)all files
 
 

diff --git a/...l/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java b/...l/tools/checkstyle/checks/newlineatendoffile/InputNewlineAtEndOfFileTestTrimProperty.java
@@ -0,0 +1,18 @@
+/*
+NewlineAtEndOfFile
+lineSeparator = \tcrlf
+fileExtensions = all files
+
+
+*/
+
+package com.puppycrawl.tools.checkstyle.checks.newlineatendoffile;
+
+/**
+ * Test case for detection of an existing CRLF newline at EOF, using the
+ * NewlineAtEndOfFileCheck.
+ * @author Martin Steiger
+ **/
+public interface InputNewlineAtEndOfFileTestTrimProperty // ok
+{
+}