fix github.com/chartjs/pull/11132

Kebechet · Jul 20, 2023 · 020c941 · 020c941
1 parent 05608b0
commit 020c941
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/helpers/helpers.dom.ts b/src/helpers/helpers.dom.ts
@@ -200,7 +200,7 @@ export function getMaximumSize(
   const maintainHeight = bbWidth !== undefined || bbHeight !== undefined;
 
   if (maintainHeight && aspectRatio && containerSize.height && height > containerSize.height) {
-    height = containerSize.height;
+    height = Math.round(containerSize.height);
     width = round1(Math.floor(height * aspectRatio));
   }
 

diff --git a/test/specs/helpers.dom.tests.js b/test/specs/helpers.dom.tests.js
@@ -545,4 +545,21 @@ describe('DOM helpers tests', function() {
 
     document.body.removeChild(container);
   });
+
+  it('should respect aspect ratio and container height and return height as integer', () => {
+    const container = document.createElement('div');
+    container.style.width = '500px';
+    container.style.height = '200px';
+
+    document.body.appendChild(container);
+
+    const target = document.createElement('div');
+    target.style.width = '500px';
+    target.style.height = '500px';
+    container.appendChild(target);
+
+    expect(helpers.getMaximumSize(target, 500, 199.975, 1)).toEqual(jasmine.objectContaining({width: 200, height: 200}));
+
+    document.body.removeChild(container);
+  });
 });