Optimize find_value_in_for_loop when no Value is found
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that a for loop iterates over `Value`s and also referes to elements not defined by the for loop, `find_value_in_for_loop` would needlessly call `ForLoop::get_current_value` for each of those lookups. `ForLoop::get_current_value` can be expensive, potentially incurring a clone of a possibly large `Value`. This change moves the `get_current_value` so that we only clone a `Value` when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that a for loop iterates over
Values and also referes to elements not defined by the for loop,find_value_in_for_loopwould needlessly callForLoop::get_current_valuefor each of those lookups.ForLoop::get_current_valuecan be expensive, potentially incurring a clone of a possibly largeValue.This change moves the
get_current_valuecall so that we only clone aValuewhen needed.