-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #28241 - upgrade vendor to v3 #8430
Conversation
Issues: #28241 |
2e9d218
to
de88287
Compare
Updated to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work fine, thanks @sharvit. Just confused about one thing below
de88287
to
347efcb
Compare
This is needed for nightly to work again. Could a Katello dev review this? |
This is causing https://projects.theforeman.org/issues/28423. When I downgrade vendor to 2.x the subscriptions page loads without error. |
That means one of the dependencies of vendor v3 must be causing it |
@waldenraines I assume it's the
But it is odd, I remember myself checking the subscription page works before the release. @LaViro can you give some insights? looks like |
react-bootstrap/react-router-bootstrap#256 |
Should we revert react-router-dom back to version 4? |
upgrade here: theforeman/foreman-js#95 |
The main upgrades are
redux-hooks
.babel
v7 andjest
v24