Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28241 - upgrade vendor to v3 #8430

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

sharvit
Copy link
Contributor

@sharvit sharvit commented Nov 12, 2019

The main upgrades are redux-hooks. babel v7 and jest v24

@theforeman-bot
Copy link

Issues: #28241

@sharvit
Copy link
Contributor Author

sharvit commented Nov 24, 2019

Updated to use @theforeman/babel

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work fine, thanks @sharvit. Just confused about one thing below

@ekohl
Copy link
Member

ekohl commented Dec 6, 2019

This is needed for nightly to work again. Could a Katello dev review this?

@johnpmitsch johnpmitsch merged commit 90ee6e7 into Katello:master Dec 6, 2019
@waldenraines
Copy link
Contributor

This is causing https://projects.theforeman.org/issues/28423. When I downgrade vendor to 2.x the subscriptions page loads without error.

@jeremylenz
Copy link
Member

That means one of the dependencies of vendor v3 must be causing it

@sharvit
Copy link
Contributor Author

sharvit commented Dec 12, 2019

@waldenraines I assume it's the react-router-dom update we introduced in version 3.4.0, see:

But it is odd, I remember myself checking the subscription page works before the release.
Can you try using vendor version v3.3.2 and verify it apear with v3.4.0?

@LaViro can you give some insights? looks like katello need to update something.

@Ron-Lavi
Copy link
Contributor

react-bootstrap/react-router-bootstrap#256
seem you were right @sharvit, someone already opened an issue 2 days ago about the compatibility with react-router-dom v5.x

@sharvit
Copy link
Contributor Author

sharvit commented Dec 12, 2019

Should we revert react-router-dom back to version 4?

@Ron-Lavi
Copy link
Contributor

upgrading react-router-bootstrap to "^0.25.0" seem to fix it:

screencapture-centos7-luna-devel-rlavi-example-com-subscriptions-1576141511566

@Ron-Lavi
Copy link
Contributor

upgrade here: theforeman/foreman-js#95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants