Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto-render): strict dollar delimiter #3926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Feb 12, 2024

  1. fix(auto-render): strict dollar delimiter

    The dollar delimiter, especially the non-display version, is disabled by default
    because it often causes errors in determining the boundary when there are at
    least two numbers followed by the `$` symbol present in one paragraph.
    
    This change makes it possible to make the delimiter stricter in determining
    the math boundary, by checking what characters come before the opening delimiter
    and what characters come after the closing delimiter.
    
    Tests are available as follows:
    
    ~~~ html
    <ul>
      <li>$E=mc^2$</li>
      <li>$E=mc^2$asdf</li>
      <li>asdf$E=mc^2$</li>
      <li>asdf$E=mc^2$asdf</li>
      <li>$E=mc^2$ asdf</li>
      <li>asdf $E=mc^2$</li>
      <li>asdf $E=mc^2$ asdf</li>
      <li>($E=mc^2$)asdf</li>
      <li>asdf($E=mc^2$)</li>
      <li>asdf($E=mc^2$)asdf</li>
      <li>asdf asdf 20$ asdf 30$ asdf asdf asdf</li>
      <li>asdf asdf $20 asdf $30 asdf asdf asdf</li>
      <li>asdf asdf $20 asdf 30$ asdf asdf asdf</li>
      <li>asdf asdf 20 $ asdf 30 $ asdf asdf asdf</li>
      <li>asdf asdf $ 20 asdf $ 30 asdf asdf asdf</li>
      <li>asdf asdf $ 20 asdf 30 $ asdf asdf asdf</li>
    </ul>
    
    <ul>
      <li>$$E=mc^2$$</li>
      <li>$$E=mc^2$$asdf</li>
      <li>asdf$$E=mc^2$$</li>
      <li>asdf$$E=mc^2$$asdf</li>
      <li>$$E=mc^2$$ asdf</li>
      <li>asdf $$E=mc^2$$</li>
      <li>asdf $$E=mc^2$$ asdf</li>
      <li>($$E=mc^2$$)asdf</li>
      <li>asdf($$E=mc^2$$)</li>
      <li>asdf($$E=mc^2$$)asdf</li>
      <li>asdf asdf 20$$ asdf 30$$ asdf asdf asdf</li>
      <li>asdf asdf $$20 asdf $$30 asdf asdf asdf</li>
      <li>asdf asdf $$20 asdf 30$$ asdf asdf asdf</li>
      <li>asdf asdf 20 $$ asdf 30 $$ asdf asdf asdf</li>
      <li>asdf asdf $$ 20 asdf $$ 30 asdf asdf asdf</li>
      <li>asdf asdf $$ 20 asdf 30 $$ asdf asdf asdf</li>
    </ul>
    
    <ul>
      <li>asdf +10$ asdf -10$ asdf</li>
      <li>asdf +10 $ asdf -10 $ asdf</li>
      <li>asdf $+10 asdf $-10 asdf</li>
      <li>asdf $ +10 asdf $ -10 asdf</li>
    </ul>
    
    <ul>
      <li>asdf +10.5$ asdf -10.5$ asdf</li>
      <li>asdf +10.5 $ asdf -10.5 $ asdf</li>
      <li>asdf $+10.5 asdf $-10.5 asdf</li>
      <li>asdf $ +10.5 asdf $ -10.5 asdf</li>
    </ul>
    
    <ul>
      <li>asdf +10,5$ asdf -10,5$ asdf</li>
      <li>asdf +10,5 $ asdf -10,5 $ asdf</li>
      <li>asdf $+10,5 asdf $-10,5 asdf</li>
      <li>asdf $ +10,5 asdf $ -10,5 asdf</li>
    </ul>
    
    <ul>
      <li>asdf +10,000,000.5$ asdf -10,000,000.5$ asdf</li>
      <li>asdf +10,000,000.5 $ asdf -10,000,000.5 $ asdf</li>
      <li>asdf $+10,000,000.5 asdf $-10,000,000.5 asdf</li>
      <li>asdf $ +10,000,000.5 asdf $ -10,000,000.5 asdf</li>
    </ul>
    
    <ul>
      <li>asdf +10.000.000,5$ asdf -10.000.000,5$ asdf</li>
      <li>asdf +10.000.000,5 $ asdf -10.000.000,5 $ asdf</li>
      <li>asdf $+10.000.000,5 asdf $-10.000.000,5 asdf</li>
      <li>asdf $ +10.000.000,5 asdf $ -10.000.000,5 asdf</li>
    </ul>
    
    <ul>
      <li>asdf1234$E=mc^2$</li>
      <li>asdf1234$E=mc^2$1234asdf</li>
      <li>$E=mc^2$1234asdf</li>
      <li>asdf1234 $E=mc^2$</li>
      <li>asdf1234 $E=mc^2$ 1234asdf</li>
      <li>$E=mc^2$ 1234asdf</li>
    </ul>
    ~~~
    taufik-nurrohman committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6bb2646 View commit details
    Browse the repository at this point in the history