Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: \dddot and \ddddot support #3834

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: \dddot and \ddddot support #3834

wants to merge 1 commit into from

Conversation

edemaine
Copy link
Member

What is the previous behavior before this PR?
\dddot and \dddot were not supported, and requested in #2744

What is the new behavior after this PR?
Fixes #2744, though italic correction is off. Example:

x+\dddot x + \ddddot y + y

KaTeX rendering:
KaTeX rendering

LaTeX rendering:
LaTeX rendering

It looks much worse for a letter A.

Also missing are tests. Is this worth a screenshot test? Maybe, for texcmp purposes?

Fixes #2744 (though italic correction is off)
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3834 (1bbb25a) into main (5dd9bc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3834   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          91       91           
  Lines        6770     6772    +2     
  Branches     1574     1574           
=======================================
+ Hits         6295     6297    +2     
  Misses        437      437           
  Partials       38       38           
Impacted Files Coverage Δ
src/macros.js 97.51% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd9bc4...1bbb25a. Read the comment docs.

@ronkok
Copy link
Collaborator

ronkok commented Oct 2, 2023

I think the rendering is about as good as we can expect to get.

The PR needs documentation updates. For the accent table in supported.md, I suggest modifying the bottom few rows as follows:

|$\dot{a}$ `\dot{a}` |$\overleftrightarrow{AB}$ `\overleftrightarrow{AB}`  |$\overbrace{AB}$ `\overbrace{AB}`
|$\ddot{a}$ `\ddot{a}`  |$\underleftrightarrow{AB}$ `\underleftrightarrow{AB}`|$\underbrace{AB}$ `\underbrace{AB}`
|$\dddot{a}$ `\dddot{a}`|$\overline{AB}$ `\overline{AB}` |$\overlinesegment{AB}$ `\overlinesegment{AB}`
|$\ddddot{a}$ `\ddddot{a}`|$\underline{AB}$ `\underline{AB}`  |$\underlinesegment{AB}$ `\underlinesegment{AB}`
|$\grave{a}$ `\grave{a}`|$\widecheck{ac}$ `\widecheck{ac}`  |$\underbar{X}$ `\underbar{X}`
|$\hat{\theta}$ `\hat{\theta}`|$\widehat{ac}$ `\widehat{ac}`||

support_table.md should also be updated. It's pretty straightforward.

With those qualifications, I am ready to (belatedly) approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support \dddot from AMSTeX
2 participants