chore(font): remove unnecessary lists and duplication in font generation scripts #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version was a big list of commands to `mftrace` in a single target. Now the code uses a pattern to create the different files in a more idiomatic way. It is not necessary to explicitly state the encoding for some files. The `mftrace` script can always find the correct encoding automatically.
This list isn't necessary because we generate a bunch of fonts in the docker container, and copy everything over. This list is implicitly defined by the output of `.ff` scripts.
IvoWingelaar
force-pushed
the
font-generation-rewrite
branch
from
5acb605
to
8c9c903
Compare
This was referenced Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No behavior is changed by this PR, as it is purely a chore to improve maintainability.