Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auto-render): concatenate content of successive text nodes #3422

Merged
merged 12 commits into from Aug 29, 2022
Merged

fix(auto-render): concatenate content of successive text nodes #3422

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc90f48
fix(auto-render): concatenate text nodes
Nov 19, 2021
78c3a92
Remove siblings only when math found
Nov 19, 2021
7e943fc
Skip siblings if they do not contain math
Nov 19, 2021
bacad4c
Fixed typo in comments
Nov 19, 2021
520b15a
Added first tests for large test nodes
Nov 22, 2021
b7537ec
Merge branch 'main' of https://github.com/KaTeX/KaTeX
Nov 22, 2021
558e8f4
Expanded testing to compare renderMathInElement with renderMathInText
Nov 23, 2021
a1041de
Simplified text node test
Nov 23, 2021
9825f6a
Change description of test
Nov 23, 2021
d0c77d0
Merge branch 'main' into main
Jan 14, 2022
be78bef
Merge branch 'main' into main
marcoesters Aug 29, 2022
d5ae92c
Update contrib/auto-render/auto-render.js
ylemkimon Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion contrib/auto-render/auto-render.js
View file
Open in desktop
Expand Up @@ -55,7 +55,17 @@ const renderElem = function(elem, optionsCopy) {
const childNode = elem.childNodes[i];
if (childNode.nodeType === 3) {
// Text node
const frag = renderMathInText(childNode.textContent, optionsCopy);
// Concatenate all sibling text nodes.
// Webkit browsers split very large text nodes into smaller ones,
// so the delimiters may be split across different nodes.
let textContentConcat = childNode.textContent;
let sibling = childNode.nextSibling;
while (sibling && (sibling.nodeType == 3)) {
textContentConcat += sibling.textContent;
sibling.remove();
ylemkimon marked this conversation as resolved.
Show resolved Hide resolved
sibling = childNode.nextSibling;
}
const frag = renderMathInText(textContentConcat, optionsCopy);
if (frag) {
i += frag.childNodes.length - 1;
elem.replaceChild(frag, childNode);
Expand Down