New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add devcontainer.json #2545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 84 84
Lines 6145 6145
Branches 1260 1260
=======================================
Hits 5766 5766
Misses 348 348
Partials 31 31 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm excited to give this a try. Once this PR is merged with the "Open codespace" button just appear in GitHub?
@@ -19,6 +19,7 @@ katexConfig.devServer = { | |||
disableHostCheck: true, | |||
host: '0.0.0.0', | |||
port: PORT, | |||
sockPort: 'location', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs do say anything about "location"
. What does this setting do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash It makes webpack-dev-server
to use the browser's location port as the socket port: webpack/webpack-dev-server#2341. For instance, when developing locally in http://localhost:7936
, it uses 7936
, and using GitPod or codespaces, they are tunneled using HTTPS, so it uses 443
. This eliminates the need to set --sockPort 443
manually.
"dbaeumer.vscode-eslint", | ||
"flowtype.flow-for-vscode", | ||
"stylelint.vscode-stylelint", | ||
"arcanis.vscode-zipfs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash Yarn 2 uses a zip-based file system, so this extension allows us to browse into a zip file in vscode.
Since it's still in limited beta, it can be started from https://github.com/codespaces. Maybe when it's general availability, a badge or button to start it may be added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for Codespaces.
Configuration for GitHub Codespaces and Visual Studio Codespaces.