Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add devcontainer.json #2545

Merged
merged 3 commits into from Sep 28, 2020
Merged

chore: add devcontainer.json #2545

merged 3 commits into from Sep 28, 2020

Conversation

ylemkimon
Copy link
Member

Configuration for GitHub Codespaces and Visual Studio Codespaces.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #2545 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          84       84           
  Lines        6145     6145           
  Branches     1260     1260           
=======================================
  Hits         5766     5766           
  Misses        348      348           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b76c0b...21c07a5. Read the comment docs.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to give this a try. Once this PR is merged with the "Open codespace" button just appear in GitHub?

@@ -19,6 +19,7 @@ katexConfig.devServer = {
disableHostCheck: true,
host: '0.0.0.0',
port: PORT,
sockPort: 'location',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs do say anything about "location". What does this setting do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbarabash It makes webpack-dev-server to use the browser's location port as the socket port: webpack/webpack-dev-server#2341. For instance, when developing locally in http://localhost:7936, it uses 7936, and using GitPod or codespaces, they are tunneled using HTTPS, so it uses 443. This eliminates the need to set --sockPort 443 manually.

"dbaeumer.vscode-eslint",
"flowtype.flow-for-vscode",
"stylelint.vscode-stylelint",
"arcanis.vscode-zipfs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbarabash Yarn 2 uses a zip-based file system, so this extension allows us to browse into a zip file in vscode.

@ylemkimon
Copy link
Member Author

Since it's still in limited beta, it can be started from https://github.com/codespaces. Maybe when it's general availability, a badge or button to start it may be added.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for Codespaces.

@ylemkimon ylemkimon merged commit 91113fb into master Sep 28, 2020
@ylemkimon ylemkimon deleted the devcontainer branch March 17, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants