-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require aiohttp from 3.8.1 to 3.8.3 and fix Typing errors #35
Conversation
@KaSroka will you create a new release for this or is there something to do left? |
Tests are failing for this one so I can't merge it. Seems like the failure is not related to this PR. I don't have time right now to fix it, I will take a look during Christmas. |
afd16e1
to
f2e0514
Compare
Ehh, typing errors are fixed and the script still works as it should, but Lint test started failing for me.
|
And that should be fixed now as well. |
Considering it was my first time fixing typing issues like that, you should look them through for sanity before merging :) |
Hmh, seems this change is back to unnecessary, for now at least, as HA Core rolled back their update. |
Awesome contribution. As HA is rolling back the version, should we update it or keep it until they update it once again? |
does this PR work with new HA version? if so, i don't see a reason why not to merge. |
It does work with the current version, as of the last commit (require aiohttp >=3.8.1, <3.8.3). |
With this change, the library is future-proof for when HA eventually does get around to updating (once they've fixed the other issues caused by 3.8.3, that is) |
This fixes compatibility with the Home Assistant HACS addon on HA 2022.12 (current beta).