Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require aiohttp from 3.8.1 to 3.8.3 and fix Typing errors #35

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

operinko
Copy link
Contributor

@operinko operinko commented Dec 1, 2022

This fixes compatibility with the Home Assistant HACS addon on HA 2022.12 (current beta).

@operinko
Copy link
Contributor Author

operinko commented Dec 7, 2022

@KaSroka @h4de5 I've been running this "patch" without issues in HA 2022.12 without issues for around a week now.

@h4de5
Copy link
Contributor

h4de5 commented Dec 8, 2022

@KaSroka will you create a new release for this or is there something to do left?

@KaSroka
Copy link
Owner

KaSroka commented Dec 11, 2022

Tests are failing for this one so I can't merge it. Seems like the failure is not related to this PR. I don't have time right now to fix it, I will take a look during Christmas.

@operinko
Copy link
Contributor Author

operinko commented Dec 11, 2022

Ehh, typing errors are fixed and the script still works as it should, but Lint test started failing for me.

would reformat toshiba_ac/_version.py

Oh no! 💥 💔 💥
1 file would be reformatted, 12 files would be left unchanged.
Error: Process completed with exit code 1.```

@operinko
Copy link
Contributor Author

And that should be fixed now as well.

@operinko
Copy link
Contributor Author

Considering it was my first time fixing typing issues like that, you should look them through for sanity before merging :)

@operinko
Copy link
Contributor Author

home-assistant/core#83795

Hmh, seems this change is back to unnecessary, for now at least, as HA Core rolled back their update.

@KaSroka
Copy link
Owner

KaSroka commented Dec 12, 2022

Awesome contribution. As HA is rolling back the version, should we update it or keep it until they update it once again?

@h4de5
Copy link
Contributor

h4de5 commented Dec 12, 2022

does this PR work with new HA version? if so, i don't see a reason why not to merge.

@operinko
Copy link
Contributor Author

It does work with the current version, as of the last commit (require aiohttp >=3.8.1, <3.8.3).
Though in hindsight, that should've been <=3.8.3 instead, might just push that commit soon :D

@operinko
Copy link
Contributor Author

With this change, the library is future-proof for when HA eventually does get around to updating (once they've fixed the other issues caused by 3.8.3, that is)

@operinko operinko changed the title Bump aiohttp to 3.8.3 Bump aiohttp to 3.8.3 and fix Typing errors Dec 12, 2022
@operinko operinko changed the title Bump aiohttp to 3.8.3 and fix Typing errors Allow aiohttp from 3.8.1 to 3.8.3 and fix Typing errors Dec 12, 2022
@operinko operinko changed the title Allow aiohttp from 3.8.1 to 3.8.3 and fix Typing errors Require aiohttp from 3.8.1 to 3.8.3 and fix Typing errors Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants