Pylint and flake8

[HebaruSan]

Background

In #212 we switched to using pytest to handle our tests, since it can drive other tools with plugins, such as pytest-mypy which we also added in that PR.

Motivation

Pytest and mypy are nice, but we'd also like to use pylint and flake8.

Changes

setup.py:

• pytest-flake8 and pytest-pylint are added to the [test] dependencies group

New parameters in the pytest.ini file:

• -p no:cacheprovider turns off caching, because it just wastes CPU/IO in CI/CD (the cache folder is going to disappear at the end), and it causes false positives and false negatives locally if you edit which checks are disabled
• --mypy --pylint --flake8 ensures that running pytest will always run mypy, pylint, and flake8. This way the individual dev doesn't have to know or remember which tools we use or how to call them; they'll all be pulled in automatically with a simpler command

Workflow step and Dockerfile:

• Now runs pytest -v which will run everything thanks to the pytest.ini changes

.pylintrc:

• Disabled the checks that are either too picky or would require large scale refactoring; we can re-enable some of these if we decide to refactor the affected code.

.flake8:

• Disabled checks for whitespace before/after colons and long lines

Lots of minor changes to code to fix complaints from the still-enabled checks from both tools.

[techman83]

Overall fantastic work! Couple of minor things, mostly due to some slight logic/formatting changes to appease the linters.

[techman83]

I added some fixes for VS Code.

• VS Code runs the test from the top level. This is both annoying and handy.
• Top level pytest.ini disables flake8/pylint/mypy. These are time consuming and the tests are already enabled within the editor, so they occur as you code.
• Enabled code auto formating. This was disabled as there was quite a lot to change, which has now since been done.

[HebaruSan]

Pushed fixes to the previous round of comments, including a new set of tests for AutoFreezer.

[techman83]

Perfect, as always, love your work! Let's merge this 😃