Fix React Hook useEffect has missing dependencies: 'image.Id' and 'im…

…age.isSystem'
KKoukiou · Feb 8, 2023 · 104fa0b · 104fa0b
1 parent 7cbed96
commit 104fa0b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/ImageHistory.jsx b/src/ImageHistory.jsx
@@ -19,14 +19,16 @@ const IdColumn = Id => {
 const ImageDetails = ({ image }) => {
     const [history, setHistory] = useState([]);
     const [error, setError] = useState(null);
+    const isSystem = image.isSystem;
+    const id = image.Id;
 
     useEffect(() => {
-        client.imageHistory(image.isSystem, image.Id).then(setHistory)
+        client.imageHistory(isSystem, id).then(setHistory)
                 .catch(ex => {
                     console.error("Cannot get image history", ex);
                     setError(true);
                 });
-    }, []);
+    }, [isSystem, id]);
 
     const columns = ["ID", _("Created"), _("Created by"), _("Size"), _("Comments")];
     let showComments = false;