Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: polkadot-0.9.43 #541

Merged
merged 16 commits into from Jul 31, 2023
Merged

chore: polkadot-0.9.43 #541

merged 16 commits into from Jul 31, 2023

Conversation

Ad96el
Copy link
Member

@Ad96el Ad96el commented Jul 21, 2023 •
edited

fixes KILTProtocol/ticket#513

  • @ggera is informed about the new CLI for starting a node
  • I slightly updated the RemoveInsecureRandomnessPallet even if it is no longer useful 👻

@Ad96el Ad96el changed the title merge develop into chore/polkadot-0.9.43 chore: polkadot-0.9.43 Jul 21, 2023
@Ad96el Ad96el requested review from ntn-x2 and weichweich July 21, 2023 12:48
ntn-x2
ntn-x2 reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor questions, before I can approve the PR!

runtimes/common/src/migrations.rs Outdated Show resolved Hide resolved
runtimes/common/src/migrations.rs Outdated Show resolved Hide resolved
runtimes/common/src/migrations.rs Outdated Show resolved Hide resolved
runtimes/common/src/migrations.rs Show resolved Hide resolved
runtimes/spiritnet/src/weights/pallet_balances.rs Outdated Show resolved Hide resolved
runtimes/peregrine/src/lib.rs Outdated Show resolved Hide resolved
weichweich
weichweich approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was the http based RPC port removed? Is there no RPC over HTTP anymore? only websockets?

nodes/standalone/Cargo.toml Outdated Show resolved Hide resolved
pallets/delegation/src/try_state.rs Show resolved Hide resolved
@Ad96el
Copy link
Member Author

Ad96el commented Jul 31, 2023

@weichweich the RPC server supports websocket and HTTP on the same socket. The HTTP was kept for backwards compatibility so yes in the future there should be only WS. Source

@Ad96el Ad96el merged commit bd843de into develop Jul 31, 2023
2 checks passed
@Ad96el Ad96el deleted the chore/polkadot-0.9.43 branch July 31, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@weichweich weichweich weichweich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.42 to 0.9.43
3 participants
@Ad96el @ntn-x2 @weichweich