This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Throw GattClosed if Gatt is closed during I/O operation #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typical behavior of
Channel
is to throw aClosedReceiveChannelException
on invocation ofclose
if areceive
is suspended. This is unfortunately a bit counter intuitive and can produce misleading stacktraces (i.e. stacktrace will includeclose
invocation but notreceive
).The following simplified snippets illustrate the issue:
In order to be more explicit with our exception stacktraces related to
Channel
cancelation: catchingClosedReceiveChannelException
and explicitly throwingGattClosed
exception (that carries original exception as it'scause
).May need to revisit this behavior in the future after
receiveOrClosed
is implemented per Kotlin/kotlinx.coroutines#330. Also noteworthy is thatreceiveOrNull
was undeprecated via Kotlin/kotlinx.coroutines#739.