Use yarn instead of npm #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
added a commit
that referenced
this pull request
Jun 28, 2019
I discovered while working on #706 that the `selector` option I passed to react-testing-library's API's (e.g. `getByLabelText()`) wasn't actually serving as a filter on the query the way I thought it was, so this fixes that.
toolness
added a commit
that referenced
this pull request
Jul 10, 2019
Aside from somehow being orders of magnitude faster than npm, it also makes it easier to install into arbitrary directories, which is especially useful for potentially getting around a very strange docker bug on Johanna's system. ## Notes * Upgraded apollo to get around apollographql/apollo-tooling#1329. * I tried using a tool to convert our `package-lock.json` to a `yarn.lock` but it didn't work, so I just built our `yarn.lock` directly from the `package.json`. This has resulted in some intermediate dependencies being different, which ultimately required me to upgrade a few packages. * One such package was `@testing-library/react`, which uncovered #707 (which we will deal with separately).
toolness
added a commit
that referenced
this pull request
Jul 10, 2019
I discovered while working on #706 that the `selector` option I passed to react-testing-library's API's (e.g. `getByLabelText()`) wasn't actually serving as a filter on the query the way I thought it was, so this fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from somehow being orders of magnitude faster than npm, it also makes it easier to install into arbitrary directories, which is especially useful for potentially getting around a very strange docker bug on Johanna's system.
Notes
Upgraded apollo to get around Code generation broken on 2.12.3 apollographql/apollo-tooling#1329.
I tried using a tool to convert our
package-lock.jsonto ayarn.lockbut it didn't work, so I just built ouryarn.lockdirectly from thepackage.json. This has resulted in some intermediate dependencies being different, which ultimately required me to upgrade a few packages.@testing-library/react, which uncovered "selector" option in react-testing-library APIs isn't doing anything #707 (which we will deal with separately).To do
npmwith 'yarn`.README.md./node_modules/during development.