[NO-TICKET] - Converting schema validation errors to warnings #869
+25
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDubber
reviewed
Apr 10, 2023
VDubber
reviewed
Apr 10, 2023
| @@ -103,7 +103,12 @@ export function createIntegrationEntity( | |||
| validateRawData(generatedEntity); | |||
|
|
|||
| if (process.env.ENABLE_GRAPH_OBJECT_SCHEMA_VALIDATION) { | |||
There was a problem hiding this comment.
I wonder if we should remove support for the env var.
There was a problem hiding this comment.
Meaning, during development we should always being logging the warnings but still not in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a persistent issue that schema validation checks can be more of a hindrance than a help in integration development. The information is valuable in helping maintain compliance with the data model, but it sometimes forces developers into the unpleasant decision between forcing in hardcoded values or using the
--disable-schema-validationflag in instances where some required data simply isn't available.