Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bocchi #1078

Merged
merged 66 commits into from
May 17, 2024
Merged

Bocchi #1078

merged 66 commits into from
May 17, 2024

Conversation

JakeFerrero
Copy link
Contributor

@JakeFerrero JakeFerrero commented May 10, 2024

Most of the files in this PR are .hbs files, and I'm not sure how familiar people are with those. I think the most important things for review are the READMEs (top-level one and the ones in /bocchi/docs, as well as the following .hbs files:
/bocchi/templates/partials/directRelationships.hbs,
/bocchi/templates/partials/mappedRelationships.hbs,
/bocchi/templates/steps/child-singleton.ts.hbs,
/bocchi/templates/steps/fetch-child-entities.ts.hbs,
/bocchi/templates/steps/fetch-entities.ts.hbs,
/bocchi/templates/steps/singleton.ts.hbs,
/bocchi/templates/top-level/src/client.ts.hbs

Honestly it may be easier to just use the two example template files, generate test graph projects, and review the resulting code.

JakeFerrero and others added 30 commits February 8, 2024 13:15
- will now create the correct type of index file for a step based on
the type of step it should be.
- renamed some template folders.
- Add functionality to copy over the base service client
- create the client template
- update types
@JakeFerrero JakeFerrero requested a review from a team as a code owner May 10, 2024 22:48
Copy link

socket-security bot commented May 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/core@7.24.5 environment, filesystem, unsafe Transitive: shell +52 10.7 MB nicolo-ribaudo
npm/@babel/preset-env@7.24.5 environment, filesystem Transitive: shell, unsafe +148 13.1 MB nicolo-ribaudo
npm/@babel/preset-typescript@7.24.1 Transitive: environment +36 6.03 MB nicolo-ribaudo
npm/@lifeomic/attempt@3.1.0 None 0 33.5 kB lifeomicdev
npm/@pollyjs/adapter-node-http@6.0.6 environment, eval, network Transitive: filesystem +26 6.92 MB offirgolan
npm/@pollyjs/core@6.0.6 eval +27 8.52 MB offirgolan
npm/@pollyjs/persister-fs@6.0.6 Transitive: environment, eval, filesystem, network, unsafe +88 8.75 MB offirgolan
npm/@types/jest@29.5.12 Transitive: environment, filesystem, unsafe +42 1.64 MB types
npm/@types/js-yaml@4.0.9 None 0 9.12 kB types
npm/@types/json2csv@5.0.7 None 0 12.1 kB types
npm/@types/lodash@4.17.4 None 0 0 B
npm/@types/vis@4.21.27 None +1 4.42 MB types
npm/@typescript-eslint/eslint-plugin@6.21.0 Transitive: environment +21 7.48 MB jameshenry
npm/@typescript-eslint/parser@6.21.0 Transitive: environment +12 2.74 MB jameshenry
npm/ajv@8.13.0 eval Transitive: unsafe +5 1.57 MB esp
npm/commander@9.5.0 environment, filesystem, shell 0 173 kB abetomo
npm/deepmerge@4.3.1 None 0 31.2 kB tehshrike
npm/ejs@3.1.10 eval, filesystem Transitive: environment, shell +5 1.16 MB mde
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-plugin-jest@27.9.0 filesystem Transitive: environment +11 1.29 MB simenb
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +82 9.96 MB eslintbot
npm/jest-extended@4.0.2 Transitive: environment +8 782 kB simenb
npm/jest@29.7.0 Transitive: environment, eval, filesystem, network, shell, unsafe +243 13.8 MB simenb
npm/lerna@7.4.2 Transitive: environment, eval, filesystem, network, shell, unsafe +479 139 MB jameshenry
npm/memfs@3.5.3 filesystem Transitive: unsafe +1 207 kB streamich
npm/neo-forgery@2.0.1 Transitive: environment, eval +85 6.32 MB yisroel
npm/neo4j-driver@4.4.11 Transitive: filesystem, network +9 3.14 MB neo4j-organization
npm/ts-jest@29.1.2 environment, filesystem, unsafe Transitive: eval, network, shell +113 8.51 MB kul
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot

🚮 Removed packages: npm/@babel/core@7.22.9, npm/@babel/preset-env@7.22.9, npm/@babel/preset-typescript@7.22.5, npm/@lifeomic/attempt@3.0.3, npm/@pollyjs/adapter-node-http@6.0.5, npm/@pollyjs/core@6.0.5, npm/@pollyjs/persister-fs@6.0.5, npm/@types/jest@29.5.3, npm/@types/js-yaml@4.0.5, npm/@types/json2csv@5.0.3, npm/@types/lodash@4.14.178, npm/@types/node@18.15.11, npm/@types/vis@4.21.23, npm/@typescript-eslint/eslint-plugin@6.2.1, npm/@typescript-eslint/parser@6.2.1, npm/ajv@8.12.0, npm/commander@9.4.0, npm/deepmerge@4.2.2, npm/eslint-config-prettier@9.0.0, npm/eslint-plugin-jest@27.2.3, npm/eslint@8.46.0, npm/jest-extended@4.0.0, npm/jest@29.6.1, npm/lerna@7.1.4, npm/memfs@3.4.1, npm/neo-forgery@2.0.0, npm/neo4j-driver@4.4.2, npm/prettier@3.0.0, npm/ts-jest@29.1.1, npm/typescript@5.1.6

View full report↗︎

VDubber
VDubber previously approved these changes May 17, 2024
@JakeFerrero JakeFerrero merged commit bdba33e into main May 17, 2024
9 checks passed
@JakeFerrero JakeFerrero deleted the IP-SPRINT-bocchi branch May 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants