Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP-15119] - Add createIntegrationHelpers #1069

Merged
merged 9 commits into from
May 17, 2024
Merged

[APP-15119] - Add createIntegrationHelpers #1069

merged 9 commits into from
May 17, 2024

Conversation

geovannimp
Copy link
Contributor

No description provided.

@socket-security Socket Security
Copy link

socket-security bot commented May 1, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jupiterone/data-model@0.61.5 Transitive: eval, unsafe +8 5.28 MB jupiterone-dev
npm/@jupiterone/integration-sdk-private-test-utils@12.7.1 None 0 0 B

🚮 Removed packages: npm/@jupiterone/data-model@0.55.0, npm/@jupiterone/data-model@0.57.0, npm/@jupiterone/integration-sdk-private-test-utils@12.7.0

View full report↗︎

@geovannimp geovannimp marked this pull request as ready for review May 13, 2024 20:08
@geovannimp geovannimp requested a review from a team as a code owner May 13, 2024 20:08
jzolo22
jzolo22 previously approved these changes May 13, 2024
View reviewed changes
eyadmba
eyadmba previously approved these changes May 14, 2024
View reviewed changes
packages/integration-sdk-core/package.json
"@jupiterone/integration-sdk-entity-validator": "^12.7.0",
"@sinclair/typebox": "^0.32.30",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can typebox be a dev dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because we need it in runtime to generate the schema.

tsconfig.base.json
@@ -6,6 +6,7 @@
"lib": ["ES2022", "DOM"],
"module": "commonjs",
"moduleResolution": "node",
"resolveJsonModule": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did we need this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason something changed in the data model and it cannot import the json schemas without this anymore 😢

@geovannimp geovannimp dismissed stale reviews from eyadmba and jzolo22 via cb3d4fb May 16, 2024 18:00
@socket-security Socket Security
Copy link

socket-security bot commented May 16, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

jzolo22
jzolo22 previously approved these changes May 16, 2024
View reviewed changes
eyadmba
eyadmba approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@eyadmba eyadmba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@geovannimp geovannimp merged commit 70a59e4 into main May 17, 2024
9 checks passed
@geovannimp geovannimp deleted the APP-15119 branch May 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyadmba eyadmba eyadmba approved these changes

@jzolo22 jzolo22 jzolo22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geovannimp @eyadmba @jzolo22