add support for using hasKey from graphObjectStore #1068
Conversation
| @@ -66,3 +66,68 @@ export class InMemoryGraphObjectStore implements GraphObjectStore { | |||
| return Promise.resolve(); | |||
| } | |||
| } | |||
|
|
|||
| export class InMemoryGraphObjectStoreWithHasKeyImpl | |||
There was a problem hiding this comment.
Why not add hasKey to the existing ObjectStore above?
| throw new IntegrationDuplicateKeyError( | ||
| `Duplicate _key detected (_key=${entity._key})`, | ||
| ); | ||
| // if this add entities contains multiple entities we need to verify it doesn't contain any duplicates within |
There was a problem hiding this comment.
The logic around this new set is messy. It introduces complexity where the duplicateKeyTracker was very straightforward. Can we move this complexity to a new implementation of the duplicateKeyTracker?
It could first check the graphObjectStore and then have a temp store that would be exist while in this loop that takes the place of this new set.
It's not a blocker but seems like we could refine the approach?
| if (hasHasKeyFn) { | ||
| return graphObjectStore.hasKey!(_key); | ||
| } else { | ||
| return duplicateKeyTracker.hasKey(_key); |
There was a problem hiding this comment.
This PR does not modify the adding of a key to the duplicateKeyTracker only the use of the hasKey. Follow up PR to no longer add to the duplicateKeyTracker is coming?
I ask because we use the duplicateKeyTracker in the above findEntity method.
Description
This PR adds support for using a
hasKeyimplementation from thegraphObjectStorerather than theDuplicateKeyTrackerif it is available.