Improve bocchi #1054
Closed
Improve bocchi #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-NCSU
approved these changes
Apr 2, 2024
JakeFerrero
suggested changes
Apr 3, 2024
There was a problem hiding this comment.
Bocchi can be used for both public and private graph repos. As such, I’d keep the files and then as an enhancement, we can have a “public” option or something in bocchi that will omit those files when creating everything.
So I think the only file here that really makes sense to go is pull_request_template. But like I said, I think this PR has given me a good idea for an enhancement to bocchi.
JakeFerrero
reviewed
Apr 3, 2024
| @@ -1,17 +0,0 @@ | |||
| # Description | |||
i5o
commented
Apr 5, 2024
packages/integration-sdk-cli/src/bocchi/templates/top-level/cortex.yaml.hbs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.