Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricts PyYaml version to 3.13 #914

Merged
merged 3 commits into from Mar 18, 2019
Merged

Restricts PyYaml version to 3.13 #914

merged 3 commits into from Mar 18, 2019

Conversation

rsmekala
Copy link
Contributor

The latest release of PyYaml(5.1) is broken.

Hardcoding the version to 3.13.

@jnpr-community-netdev
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Mar 18, 2019 •
edited

Coverage Status

Coverage remained the same at 96.835% when pulling 2ef8ba0 on rsmekala:yaml_tests_fix into fdeb070 on Juniper:master.

@vnitinv
Copy link
Contributor

vnitinv commented Mar 18, 2019

read this for more details:
yaml/pyyaml#265

vnitinv
vnitinv approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@vnitinv vnitinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it <=

@rsmekala rsmekala merged commit 2098052 into Juniper:master Mar 18, 2019
@rsmekala rsmekala deleted the yaml_tests_fix branch March 19, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnitinv vnitinv vnitinv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsmekala @jnpr-community-netdev @coveralls @vnitinv