forked from puma/puma
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
Puma::StateFile#load
returns empty string instead of nil (puma#…
…2810) Bug introduced in 2b6968f puma#2784 Until 5.5.2, empty values were read as `nil`. Since 5.6.0, empty values are read as `""`.
- Loading branch information
1 parent
5dca6d1
commit 95874f7
Showing
2 changed files
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
require_relative "helper" | ||
require_relative "helpers/tmp_path" | ||
|
||
require 'puma/state_file' | ||
|
||
class TestStateFile < Minitest::Test | ||
include TmpPath | ||
|
||
def test_load_empty_value_as_nil | ||
state_path = tmp_path('.state') | ||
File.write state_path, <<-STATE | ||
--- | ||
pid: 123456 | ||
control_url: | ||
control_auth_token: | ||
running_from: "/path/to/app" | ||
STATE | ||
|
||
sf = Puma::StateFile.new | ||
sf.load(state_path) | ||
assert_equal 123456, sf.pid | ||
assert_equal '/path/to/app', sf.running_from | ||
assert_nil sf.control_url | ||
assert_nil sf.control_auth_token | ||
|
||
end | ||
end |