Skip to content

Commit

Permalink
Don't close systemd activated socket on pumactl restart (puma#2563)
Browse files Browse the repository at this point in the history
Closes puma#2504
  • Loading branch information
MSP-Greg authored and JuanitoFatas committed Sep 9, 2022
1 parent 73d0c9c commit 2776719
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 7 deletions.
9 changes: 9 additions & 0 deletions History.md
@@ -1,3 +1,12 @@
## Master

* Features
* Your feature goes here <Most recent on the top, like GitHub> (#Github Number)

* Bugfixes
* Your bugfix goes here <Most recent on the top, like GitHub> (#Github Number)
* Don't close systemd activated socket on pumactl restart (#2563, #2504)

## 5.2.2 / 2021-02-22

* Bugfixes
Expand Down
18 changes: 11 additions & 7 deletions lib/puma/binder.rb
Expand Up @@ -258,14 +258,18 @@ def parse(binds, logger, log_msg = 'Listening')
end

# Also close any unused activated sockets
@activated_sockets.each do |key, sock|
logger.log "* Closing unused activated socket: #{key.join ':'}"
begin
sock.close
rescue SystemCallError
unless @activated_sockets.empty?
fds = @ios.map(&:to_i)
@activated_sockets.each do |key, sock|
next if fds.include? sock.to_i
logger.log "* Closing unused activated socket: #{key.first}://#{key[1..-1].join ':'}"
begin
sock.close
rescue SystemCallError
end
# We have to unlink a unix socket path that's not being used
File.unlink key[1] if key.first == :unix
end
# We have to unlink a unix socket path that's not being used
File.unlink key[1] if key[0] == :unix
end
end

Expand Down

0 comments on commit 2776719

Please sign in to comment.