Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Recipes to Substrate 3.0 #419

Merged
merged 83 commits into from Apr 15, 2021
Merged

Upgrade Recipes to Substrate 3.0 #419

merged 83 commits into from Apr 15, 2021

Conversation

JoshOrndorff
Copy link
Owner

@JoshOrndorff JoshOrndorff commented Mar 22, 2021

This Pull Request updates the Substrate Recipes to use the published Substrate 3.0 crates along with other ecosystem updates such as parity-scale-codec, substrate-wasm-builder, and substrate-fixed.

All code is compiling and passing tests locally. We just have to get CI sorted out. Thanks @jimmychu0807 and @sacha-l for the help.

Checklist:

  • Make all pallets compile
  • Make all runtimes compile
  • Make all nodes compile
  • Make all tests pass
  • General code quality review and cleanup
  • Fix links
  • Update writeups

@NukeManDan NukeManDan marked this pull request as draft March 23, 2021 04:15
@NukeManDan NukeManDan added new recipe 🍳 Request to add a new recipe vision 👀 related to purpose, direction, overarching objectives wip recipe⏰ work-in-progress recipe (specify branch) labels Mar 23, 2021
@JoshOrndorff
Copy link
Owner Author

JoshOrndorff commented Mar 31, 2021

@jimmychu0807 Basically this is what I need your help with.

https://github.com/JoshOrndorff/recipes/blob/joshy-3.0/pallets/ocw-demo/Cargo.toml#L13-L14

alt_serde = { version = "1", default-features = false, features = ["derive"] }
serde_json = { version = "1", default-features = false, git = "https://github.com/Xanewok/json", branch = "no-std", features = ["alloc"] }

Ohh! Maybe this will help serde-rs/json#606

@TriplEight
Copy link
Contributor

Looking at the other PRs in this repo I see it's possible to compile Substrate on those Gihub's subtle virtual machines, so I think the reason is in how do you test.
Consider testing the similar way as in substrate

JoshOrndorff and others added 2 commits April 13, 2021 10:33
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
text/basic-pow.md Outdated Show resolved Hide resolved
text/custom-rpc.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jimmychu0807 jimmychu0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow @JoshOrndorff what a feat! Thanks for the Recipe update.

Just two minor suggestion on a few sentences. Also, is substrate-fixed API changed that our code doesn't work with their latest stable release?

I think you can merge the recipe code once you accept the suggestions. I would prefer to look into the CI issue in another time.

@jimmychu0807
Copy link
Collaborator

jimmychu0807 commented Apr 14, 2021

@TriplEight
Copy link
Contributor

TriplEight commented Apr 14, 2021

I've fixed CI improving the caching. Previous setup was conflicting with "run in a container" setup.
However, the testing itself takes a whopping 25 min in GHA (and on my testing machine it took under 4 minutes), this might be a sign to use a serious CI system.

JoshOrndorff and others added 3 commits April 14, 2021 16:54
Co-authored-by: Jimmy Chu <jimmychu0807@gmail.com>
Co-authored-by: Jimmy Chu <jimmychu0807@gmail.com>
@jimmychu0807
Copy link
Collaborator

thanks @TriplEight for fixing the CI

@jimmychu0807 jimmychu0807 merged commit 53f7ce1 into JoshOrndorff:master Apr 15, 2021
@TriplEight
Copy link
Contributor

I wonder why since after 8fc5203 the CI jobs became duplicated.
Before:
image
after:
image
Ran an experimental branch from a fork and it was not the case. #431

Maybe it happened due to I committed to this PR directly (and Pr was from a @JoshOrndorff 's fork)

@jimmychu0807
Copy link
Collaborator

jimmychu0807 commented Apr 15, 2021

@TriplEight Let see in future PRs if these CI workflow resume to be normal or run in a duplicated fashion. Don't worry about it too much for now.

hupsuni added a commit to hupsuni/recipes that referenced this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new recipe 🍳 Request to add a new recipe vision 👀 related to purpose, direction, overarching objectives wip recipe⏰ work-in-progress recipe (specify branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants