New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Recipes to Substrate 3.0 #419
Conversation
@jimmychu0807 Basically this is what I need your help with. https://github.com/JoshOrndorff/recipes/blob/joshy-3.0/pallets/ocw-demo/Cargo.toml#L13-L14 alt_serde = { version = "1", default-features = false, features = ["derive"] }
serde_json = { version = "1", default-features = false, git = "https://github.com/Xanewok/json", branch = "no-std", features = ["alloc"] } Ohh! Maybe this will help serde-rs/json#606 |
Looking at the other PRs in this repo I see it's possible to compile Substrate on those Gihub's subtle virtual machines, so I think the reason is in how do you test. |
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow @JoshOrndorff what a feat! Thanks for the Recipe update.
Just two minor suggestion on a few sentences. Also, is substrate-fixed
API changed that our code doesn't work with their latest stable release?
I think you can merge the recipe code once you accept the suggestions. I would prefer to look into the CI issue in another time.
I believe this: |
I've fixed CI improving the caching. Previous setup was conflicting with "run in a container" setup. |
Co-authored-by: Jimmy Chu <jimmychu0807@gmail.com>
Co-authored-by: Jimmy Chu <jimmychu0807@gmail.com>
thanks @TriplEight for fixing the CI |
I wonder why since after Maybe it happened due to I committed to this PR directly (and Pr was from a @JoshOrndorff 's fork) |
@TriplEight Let see in future PRs if these CI workflow resume to be normal or run in a duplicated fashion. Don't worry about it too much for now. |
Upgrade Recipes to Substrate 3.0 (JoshOrndorff#419)
This Pull Request updates the Substrate Recipes to use the published Substrate 3.0 crates along with other ecosystem updates such as
parity-scale-codec
,substrate-wasm-builder
, andsubstrate-fixed
.All code is compiling and passing tests locally. We just have to get CI sorted out. Thanks @jimmychu0807 and @sacha-l for the help.
Checklist: