Decouple link checking from mdbook

.github/workflows/build-book.yml

@@ -18,10 +18,5 @@ jobs:
         mdbook-version: '0.3.7'
         # mdbook-version: 'latest'
 
-    - name: Install mdbook-linkcheck
-      run: |
-          curl -LSfs https://japaric.github.io/trust/install.sh | \
-            bash -s -- --git Michael-F-Bryan/mdbook-linkcheck
-
     - name: Build Book
       run: mdbook build

.github/workflows/build-deploy-book.yml

@@ -17,11 +17,6 @@ jobs:
         mdbook-version: '0.3.5'
         # mdbook-version: 'latest'
 
-    - name: Install mdbook-linkcheck
-      run: |
-          curl -LSfs https://japaric.github.io/trust/install.sh | \
-            bash -s -- --git Michael-F-Bryan/mdbook-linkcheck
-
     - name: Build Book
       run: mdbook build
 

.github/workflows/link-check.yml

@@ -0,0 +1,21 @@
+name: Check Links
+
+on:
+  pull_request:
+    branches:
+    - master
+    - develop
+  push:
+    branches:
+    - master
+    - develop
+
+jobs:
+  markdown-link-check:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - uses: gaurav-nelson/github-action-markdown-link-check@v1
+      with:
+        use-quiet-mode: 'yes'
+        config-file: '.github/workflows/mlc_config.json'

.github/workflows/mlc_config.json

@@ -0,0 +1,10 @@
+{
+    "ignorePatterns": [
+        {
+            "pattern": "^https://crates.io"
+        },
+        {
+            "pattern": "^https://github.com/substrate-developer-hub/recipes/tree/master"
+        }
+    ]
+}

README.md

@@ -1,6 +1,7 @@
 # <a href="https://substrate.dev/recipes">Substrate Recipes</a> 🍴😋🍴
 
 ![Build Status](https://img.shields.io/endpoint.svg?url=https%3A%2F%2Factions-badge.atrox.dev%2Fsubstrate-developer-hub%2Frecipes%2Fbadge%3Fref%3Dmaster&style=flat)
+<!-- markdown-link-check-disable-next-line -->
 ![Lines of Code](https://tokei.rs/b1/github/substrate-developer-hub/recipes)
 
 _A Hands-On Cookbook for Aspiring Blockchain Chefs_
@@ -21,7 +22,7 @@ There are five primary directories in this repository:
 -   **Consensus**: Consensus engines for use in Substrate nodes.
 -   **Nodes**: Complete Substrate nodes ready to run.
 
-The book is built with [mdbook](https://rust-lang-nursery.github.io/mdBook/) and deployed via
+The book is built with [mdbook](https://github.com/rust-lang/mdBook) and deployed via
 [github pages](https://pages.github.com/).
 
 ## License

pallets/execution-schedule/README.md

@@ -26,5 +26,3 @@ pub struct Task<BlockNumber> {
     expected_execution: BlockNumber,
 }
 ```
-
-I wrote more about this [here](../../../../src/testing/schedule.md).

text/2-appetizers/2-storage-values.md

@@ -28,7 +28,7 @@ about this value much, and it is fine to use the name of the pallet itself.
 
 This pallet has two storage items, both of which are single storage values. Substrate's storage API
 also supports more complex storage types which are
-[covered in the entrees](../3-entrees/storage-api/index.html). The fundamentals for all types are
+[covered in the entrees](../3-entrees/storage-api/index.md). The fundamentals for all types are
 the same.
 
 Our first storage item is a `u32` value which is declared with this syntax

text/3-entrees/off-chain-workers/storage.md

@@ -13,18 +13,18 @@ Off-chain workers are asynchronously run during block import. Since ocws are not
 they run, at any single instance there could be multiple ocws running, being initiated by previous
 block imports. See diagram below.
 
-![More than one off-chain workers at a single instance](/img/multiple-ocws.png)
+![More than one off-chain workers at a single instance](../../img/multiple-ocws.png)
 
 The storage has a similar API usage as on-chain
-[`StorageValue`](/2-appetizers/2-storage-values.html) with `get`, `set`, and `mutate`. `mutate` is
+[`StorageValue`](../../2-appetizers/2-storage-values.md) with `get`, `set`, and `mutate`. `mutate` is
 using a [`compare-and-set`](https://en.wikipedia.org/wiki/Compare-and-swap) pattern. It compares the
 contents of a memory location with a given value and, only if they are the same, modifies the
 contents of that memory location to a new given value. This is done as a single atomic operation.
 The atomicity guarantees that the new value is calculated based on up-to-date information; if the
 value had been updated by another thread in the meantime, the write would fail.
 
 In this recipe, we will add a cache and lock over our previous
-[http fetching example](./http-json.html). If the cached value existed, we will return using the
+[http fetching example](./http-json.md). If the cached value existed, we will return using the
 cached value. Otherwise we acquire the lock and then fetch from github public API and save it to the
 cache.
 

text/3-entrees/off-chain-workers/transactions.md

@@ -368,4 +368,4 @@ As in signed transactions, we prepare a function reference with its parameters a
 ## Testing
 
 For writing test cases for off-chain worker, refer to our
-[testing section](/3-entrees/testing/off-chain-workers.md).
+[testing section](../testing/off-chain-workers.md).

text/3-entrees/randomness.md

@@ -119,5 +119,6 @@ these randomness sources. If you'd like to get into the research, here are some
 
 -   [https://github.com/paritytech/ink/issues/57](https://github.com/paritytech/ink/issues/57)
 -   [https://wiki.polkadot.network/docs/en/learn-randomness](https://wiki.polkadot.network/docs/en/learn-randomness)
+<!-- markdown-link-check-disable-next-line -->
 -   [http://www.cse.huji.ac.il/~nati/PAPERS/coll_coin_fl.pdf](http://www.cse.huji.ac.il/~nati/PAPERS/coll_coin_fl.pdf)
 -   [https://eccc.weizmann.ac.il/report/2018/140/](https://eccc.weizmann.ac.il/report/2018/140/)

text/3-entrees/storage-api/ringbuffer.md

@@ -201,10 +201,8 @@ oldest item in the queue if a new item is pushed into a full queue by incrementi
 > The ringbuffer should be agnostic to the concrete `Index` type used. In order to decrement and
 > increment the start and end index, though, any concrete type needs to implement `wrapping_add` and
 > `wrapping_sub`. Because `std` does not provide such a trait, we need another way to require this
-> behavior. One possbility would be using the
-> [`num_traits` crate](https://crates.io/crates/num-traits), but to keep things simple here we just
-> implement our own trait `WrappingOps` for the types we want to support (`u8`, `u16`, `u32` and
-> `u64`).
+> behavior. We just implement our own trait `WrappingOps` for the types we
+> want to support (`u8`, `u16`, `u32` and `u64`).
 
 The last function we implement is `pop`:
 

text/3-entrees/testing/mock.md

@@ -1,6 +1,6 @@
 # Mock Runtime for Unit Testing
 
-_See [Testing](./index.html) page for list of kitchen pallets with unit test coverage._
+_See [Testing](./index.md) page for list of kitchen pallets with unit test coverage._
 
 There are two main patterns on writing tests for pallets. We can put the tests:
 

text/3-entrees/testing/off-chain-workers.md

@@ -1,7 +1,7 @@
 # Off-chain Worker Test Environment
 
 Learn more about how to set up and use offchain-workers in the
-[offchain-demo entree](/3-entrees/off-chain-workers/index.md).
+[offchain-demo entree](../off-chain-workers/index.md).
 
 ## Mock Runtime Setup
 

text/drafts/chainspec.md

@@ -1,6 +1,6 @@
 # Minimal Blockchain Configuration
 
-[Substate Node](https://github.com/paritytech/substrate/tree/master/node) is Substrate's pre-baked
+[Substate Node](https://github.com/paritytech/substrate/tree/master/bin/node) is Substrate's pre-baked
 blockchain client. By creating and modifying a Substrate Node chain specification file, it is easy
 to configure a new chain and launch a corresponding testnet.
 

text/drafts/ensure.md

@@ -10,7 +10,7 @@ storage changes.** This is similar to
 [`require()`](https://ethereum.stackexchange.com/questions/15166/difference-between-require-and-assert-and-the-difference-between-revert-and-thro)
 checks at the top of function bodies in Solidity contracts.
 
-In the [set storage and iteration](../storage/iterate.md), a vector was stored in the runtime to
+In the set storage and iteration recipe, a vector was stored in the runtime to
 allow for simple membership checks for methods only available to members.
 
 ```rust, ignore

text/drafts/optimizations.md

@@ -43,6 +43,7 @@ to._ - [src](http://wiki.c2.com/?PrematureOptimization)
 
 **Rust API Guidelines**
 
+<!-- markdown-link-check-disable-next-line -->
 -   [Official Rust API Guidelines](https://rust-lang-nursery.github.io/api-guidelines/about.html)
 -   [Rust Unofficial Design Patterns](https://github.com/rust-unofficial/patterns)
 -   [Elegant Library API Guidelines](https://deterministic.space/elegant-apis-in-rust.html) by
@@ -56,10 +57,8 @@ We call an algorithm _efficient_ if its running time is polynomial in the size o
 _highly efficient_ if its running time is linear in the size of the input. It is important for all
 on-chain algorithms to be highly efficient, because they must scale linearly as the size of the
 Polkadot network grows. In contrast, off-chain algorithms are only required to be efficient. -
-[Web3 Research](http://research.web3.foundation/en/latest/polkadot/NPoS/1.intro/)
+[Web3 Research](https://research.web3.foundation/en/latest/polkadot/NPoS/)
 
-_See [Substrate Best Practices](https://substrate.dev/docs/en/tutorials/tcr/) for more details on
-how efficiency influences the runtime's economic security._
 
 **Related Reading**
 
@@ -152,7 +151,6 @@ To dive deeper down these 🐰 holes
 
 -   [RustLatam 2019 - Without Boats: Zero-Cost Async IO](https://www.youtube.com/watch?v=skos4B5x7qE)
 -   [Introduction to Async/Await Programming (withoutboats/wakers-i):](https://boats.gitlab.io/blog/post/wakers-i/)
--   [Futures (by Aaron Turon)](http://aturon.github.io/2016/08/11/futures/)
 
 **Projects**