Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix DeprecationWarning: Module.issuer: Use new ModuleGraph API #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MalikBen
Copy link

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
Removes warning by using ModuleGraph in case of webpack version >= 5
What is the current behavior? (You can also link to an open issue here)
webpack5 build throws a DeprecationWarning
[DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API
See #418
What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills contributing guidelines

@zhongzhong0505
Copy link

checks failed , @MalikBen

@dmnsgn
Copy link
Contributor

dmnsgn commented Jan 9, 2021

@MalikBen

Looks like test for Env "webpack-2" are failing. Does webpack 2 exports version? If not then can you try changing:

const isWebpackGreaterThan5 = version[0] >= 5;

to

const isWebpackGreaterThan5 = version && version[0] >= 5;

@flyyang
Copy link

flyyang commented Jan 21, 2021

ping @MalikBen

1 similar comment
@liuliangsir
Copy link

ping @MalikBen

@b-e-r-t-o
Copy link

@pbn04001 can I open a new PR to fix this warning?

@d3x42
Copy link
Contributor

d3x42 commented Apr 10, 2021

@b-e-r-t-o Yes, you can

@MalikBen
Copy link
Author

MalikBen commented Dec 8, 2022

Hi, I'm sorry I was receiving all the e-mails in my spam box, is this issue fixed ? Should I close it ?

@Eli-Black-Work
Copy link

For what it's worth, I'm no longer seeing this issue. Probably best to wait until a few others weight in before closing it, though, IMHO 🙂

@Eli-Black-Work
Copy link

Wait, nvm, I was testing with an outdated version of svg-sprite-loader. Please disregard my answer 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants