Redraw immediately on panel size change #923
Conversation
| tryRedrawImmediately() | ||
| } | ||
|
|
||
| override fun setBounds(x: Int, y: Int, width: Int, height: Int) { |
There was a problem hiding this comment.
org.jetbrains.skiko.SkiaLayerTest[awt] > resize window[awt] FAILED
fails on Windows
There was a problem hiding this comment.
Yep, I saw this. Regardless of CI state, please check the fix locally to make sure that we agree that the change makes sense
There was a problem hiding this comment.
The fix is okay, though I see "jumps" on resize. But it is better than the current behaviour.
chrome_LBIg91l8X8.mp4
Regarding the failed test - it fails locally as well, and it is the only failed test.
There was a problem hiding this comment.
The problem was with software renderer - it just stops to display updates after try to redraw during layout despite any render/flush/... calls after that. Spend some time on it, but the reason isn't clear.
Added a check to apply my fix only to Direct3D to not just fix this issue but also reduce the scope of this change
There was a problem hiding this comment.
Do this fix help Metal/OpenGL as well?
There was a problem hiding this comment.
Help with what? The issue was only in Windows/DirectX
Fixes a couple of issues like: JetBrains/compose-multiplatform#4744 (TODO: collect all references)
Before (slow-mo)
doc_2024-05-14_18-01-27.mp4
After (slow-mo)
video_2024-05-14_18-01-41.mp4