Add isMaximized and setMaximized methods to PlatformOperations #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedRejeb
changed the title
|
Thanks for the PR! Sorry for the delay, I plan to look at it more closely later. There are potential race conditions with the current code, I am still not sure if they are relevant or not, I need to look at it more carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: JetBrains/compose-multiplatform-core#1148
Hi,
I added
setMaximizedmethods toPlatformOperationswhich is using a native implementation for macos.I added
maximizedproperty in HardwareLayer and SkiaLayer.awt.This will fix a problem that we have on Compose Desktop when we try to do something like this: floating -> fullscreen -> maximized, the window will stay fullscreen, more details in the PR above.
The swing implementation on Windows and Linux is not tested yet.
The current implementation is not final, but it's working, so let me know what you think.