Resolve #768: Permit creating arbitrary color spaces #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jul 25, 2023
|
Thanks for running it on the CI! The build failures were kind of expected as I did not manage to test the C++ code under |
|
I believe all errors are fixed now. It would be amazing if someone could re-run the workflow to see whether the tests now pass on all platforms. |
dima-avdeev-jb
requested review from
dima-avdeev-jb
and removed request for
dima-avdeev-jb
|
Thanks for PR! We will need some time to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset implements the ideas from issue #768.
While working on this, I realized that the method
ColorSpace::convertdoes not function as you would expect, since it completely disregards the gamut. I presume that some client depends on this method, so I haven't touched it, but added a comment that warns about its behavior.If you'd like me to change anything, be it API-wise, style-wise, or anything really, feel free to point it out.