Add test for swing interop #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API can be improved when more tests will be written. May be you know some other usecases that we can handle in tests? I thought about resizing, but cannot imagine how to write test for such dynamic behaviour |
I would say, we need to check all cases from SkiaLayerTest. They also applicable to SkiaSwingLayer |
|
Not all, but I agree we can check smth like multiple windows and multiple components. Thank you, will write! |
Resizing needs to be tested for 2 cases:
|
igordmn
reviewed
Jun 29, 2023
skiko/src/awtTest/kotlin/org/jetbrains/skiko/SkiaSwingLayerTest.kt
Outdated
Show resolved
Hide resolved
skiko/src/awtTest/kotlin/org/jetbrains/skiko/SkiaSwingLayerTest.kt
Outdated
Show resolved
Hide resolved
|
|
||
| private fun fillSkikoView(color: Color = Color.RED): SkikoView = object : SkikoView { | ||
| override fun onRender(canvas: Canvas, width: Int, height: Int, nanoTime: Long) { | ||
| canvas.drawRect(Rect(0f, 0f, width.toFloat(), height.toFloat()), Paint().apply { |
There was a problem hiding this comment.
Worth add a semi-transparent green background around the rect, to check blending (to the Swing rect as well)
There was a problem hiding this comment.
I think it is worth adding it only for swing here. Will do
Walingar
force-pushed
the
nr/swing-interop-tests
branch
from
5fc1b37
to
a9a040e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added test for z-ordering with SkiaSwingLayer. Also, I checked that test fails with heavy-weight SkiaLayer component