Add binding for SkCanvas::getSurface() #593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Sep 21, 2022
| * | ||
| * @return the surface this canvas is owned by, or null if it is not owned by any surface. | ||
| */ | ||
| val surface: Surface? |
There was a problem hiding this comment.
Could you add a simple test to CanvasTest?
No, it was written with ultra modern copy-paste technique :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://api.skia.org/classSkCanvas.html#aa55c3571746344d0887ed56abd2f9973
Btw is there some conversion tool? Or was it all done with rewrite/regex?