Don't depend on kotlinx-coroutines-swing #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it overrides Dispatchers.Main Fixes JetBrains/compose-multiplatform#1943 on skiko side
igordmn
commented
Mar 9, 2022
| @@ -110,7 +109,7 @@ internal open class HardwareLayer( | |||
| // and its accessibility context. This timeout is used to deal with concurrency | |||
| // TODO Find more reliable procedure | |||
| resetFocusAccessibleJob?.cancel() | |||
| resetFocusAccessibleJob = GlobalScope.launch(Dispatchers.Swing) { | |||
| resetFocusAccessibleJob = GlobalScope.launch(MainUIDispatcher) { | |||
There was a problem hiding this comment.
Maybe we rename MainUIDispatcher to Dispatchers.SkikoUI?
There was a problem hiding this comment.
Well, it's hard question, as Dispatchers.XXX assumes that it's part of coroutines library. Guess we'd better keep as is.
olonho
approved these changes
Mar 9, 2022
manu-unter
pushed a commit
to manu-unter/skiko
that referenced
this pull request
May 16, 2022
Because it overrides Dispatchers.Main Fixes JetBrains/compose-multiplatform#1943 on skiko side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it overrides Dispatchers.Main
Fixes JetBrains/compose-multiplatform#1943 on skiko side