Show return type hints on last line of pipeline chain #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@DedSec256 Please rebase on |
auduchinok
reviewed
Apr 26, 2024
Comment on lines
+1
to
+2
| [ 1 ]||(0) | ||
| |> |
| |> ignore | ||
| |> id |
| |> List.iter ignore | ||
|
|
||
| [1]||(8) | ||
| |> List.map ignore||(9) |
| let f _ _ = () | ||
|
|
||
| 1||(12) | ||
| |> f||(13) |
ReSharper.FSharp/test/data/features/daemon/pipeChainTypeHints/Skipped 05 - Inner pipe.fs.gold
Show resolved
Hide resolved
Comment on lines
59
to
61
| .IgnoreParentParens() | ||
| .GetOutermostParentExpressionFromItsReturn() | ||
| .IgnoreParentParens() |
There was a problem hiding this comment.
I wonder if this parens skipping would be better to be inside GetOutermostParentExpressionFromItsReturn instead of having to do it twice later?
Comment on lines
+96
to
+93
| let rec skipFunArgs (t: FSharpType) = | ||
| if t.IsFunctionType then skipFunArgs t.GenericArguments[1] else t |
There was a problem hiding this comment.
I'm not sure I can easily follow the logic here. Could you add some comments/examples, please?
ReSharper.FSharp/src/FSharp/FSharp.Psi.Daemon/src/Stages/PipeChainTypeHintStage.fs
Show resolved
Hide resolved
auduchinok
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/RIDER-77585/Show-return-type-hints-on-last-line-of-pipeline-chain