Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding.GetParametersGroups API [WIP] #406

Open
wants to merge 5 commits into
base: net223
Choose a base branch
from

Conversation

DedSec256
Copy link
Contributor

No description provided.

@DedSec256 DedSec256 force-pushed the net223-dedsec256-GetParametersGroups-api branch from d8cfae9 to 12ef383 Compare September 5, 2022 13:45
@auduchinok
Copy link
Member

@DedSec256 What's the state here?

@DedSec256
Copy link
Contributor Author

@auduchinok, I'll try to finish it soon

@DedSec256 DedSec256 force-pushed the net223-dedsec256-GetParametersGroups-api branch from 12ef383 to 916adf4 Compare September 27, 2022 14:05
@auduchinok
Copy link
Member

@DedSec256 What do you think about splitting getting the parameter nodes and getting their names into separate APIs? Maybe something like this:

IReadOnlyList<IReadOnlyList<ITreeNode>> GetParameterNodes(ITreeNode node)
string GetParameterName(ITreeNode node)

The current API does two unrelated enough things and it doesn't seem right.

@auduchinok
Copy link
Member

A side note: we should try to build common interfaces that would remove this ITreeNode processing and use typed getters instead. That could be quite challenging due to different representations of parameters and may require us to change the tree structure, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants