Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantomas: add ZoneMarker #322

Open
wants to merge 1 commit into
base: net213
Choose a base branch
from
Open

Conversation

DedSec256
Copy link
Contributor

@DedSec256 DedSec256 commented Nov 8, 2021

Fix for

image

@auduchinok
Copy link
Member

@DedSec256 What are implications of this change? You're suggesting to merge it to 213 quite late in the release cycle, so it would be good to better understand what's going on. What didn't work without this change? If everything worked as expected, is the error correct at all?

@DedSec256
Copy link
Contributor Author

DedSec256 commented Nov 9, 2021

What didn't work without this change? If everything worked as expected, is the error correct at all?

Fantomas works as expected. Perhaps for some reason, the analyzer did not work correctly, however, I also found that the PR error could be fixed by fixing the namespace in ProjectModelBase ZoneMarker

image

@auduchinok
Copy link
Member

however I also found that the PR error is fixed by fixing the namespace in ProjectModelBase ZoneMarker

What does "fixing the namespace" mean? What was needing fixing?

Perhaps for some reason the analyzer did not work correctly

If you found it indeed works incorrectly, please do report it.

@DedSec256
Copy link
Contributor Author

What does "fixing the namespace" mean? What was needing fixing?

Changing namespace to the corresponding location, as shown in the screenshot above
JetBrains.ReSharper.Plugins.FSharp.ProjectModelBase -> JetBrains.ReSharper.Plugins.FSharp

If you found it indeed works incorrectly, please do report it.

It was to the question

If everything worked as expected, is the error correct at all?

It is possible that the zone analyzer didn't correctly report the error. This should be dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants