Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Providers: add hot-reload for tp developers #269

Open
wants to merge 5 commits into
base: net213
Choose a base branch
from

Conversation

DedSec256
Copy link
Contributor

@DedSec256 DedSec256 commented May 25, 2021

  • Restart type providers action
  • Assemblies shadow copying mode for type providers debugging
  • Add tests
  • Add hot-reload?

JetBrains1

@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch 2 times, most recently from c127249 to 5e278ff Compare May 31, 2021 12:33
@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch 3 times, most recently from ed40f59 to 57a5ba3 Compare June 7, 2021 16:00
@DedSec256 DedSec256 changed the title Type Providers: add 'Restart type providers' action [WIP] Type Providers: add 'Restart type providers' action Jun 8, 2021
@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch from 57a5ba3 to ea1ca5e Compare June 24, 2021 19:15
@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch from ea1ca5e to fe561ae Compare July 12, 2021 10:44
@auduchinok
Copy link
Member

@DedSec256 Could you target net213 instead please? Thanks. Also, there're some conflicts. 🙂

@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch from b55b648 to 8b21f37 Compare July 15, 2021 21:50
@DedSec256 DedSec256 force-pushed the net212-ber.a-restartTypeProvidersAction branch from 8b21f37 to 7a3fbdb Compare July 15, 2021 22:05
@DedSec256 DedSec256 changed the base branch from net212 to net213 July 15, 2021 22:07
@@ -52,6 +53,13 @@ type internal TypeProvidersCache() =
if not hasValue then failwith $"Cannot get type provider {id} from TypeProvidersCache"
else proxyTypeProvidersPerId.[id]

member x.GetProvidersLocations() =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use outputAssemblyPath since multiple projects can have the same resolutionFolder

@DedSec256
Copy link
Contributor Author

We have no more need in manual 'Restart type providers' action since we are able to restart type providers via project reloading.

@DedSec256 DedSec256 changed the title Type Providers: add 'Restart type providers' action Type Providers: add hot-reload for tp developers Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants