Split function annotation into argument and return type annotations #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saul
approved these changes
Nov 15, 2020
| open JetBrains.ReSharper.Plugins.FSharp.Psi.Tree | ||
|
|
||
| [<ContextAction(Name = "AnnotateFunctionArgumentTypes", Group = "F#", | ||
| Description = "Annotate function with argument types")>] |
There was a problem hiding this comment.
A parameter is a variable in a method definition. When a method is called, the arguments are the data you pass into the method's parameters.
Suggested change
| Description = "Annotate function with argument types")>] | |
| Description = "Annotate function parameter types")>] |
|
@mcon Thanks for this PR! We're currently finishing the last things for upcoming 2020.3 release, and these changes should go to 2021.1 EAP instead. I'll create a working |
|
Sounds good to me! |
|
@mcon, your PR targets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously suggested, have split function annotation into return type and argument annotation.
Most of the diffs here are partitioning tests between each new action.
One this one's in, I'll probably take a look at generalising this to class members.