feat: support for npm package manager in Kotlin/JS #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahhaggarty
force-pushed
the
2-0-0-doc-update
branch
from
d35b044
to
be6f58f
Compare
danil-pavlov
force-pushed
the
npm-package-manager
branch
from
b1e541b
to
53ead7f
Compare
zamulla
reviewed
May 22, 2024
docs/topics/js/js-project-setup.md
Outdated
| for managing [npm](https://www.npmjs.com/) dependencies in background and can build a JavaScript bundle from a Kotlin project | ||
| typical for JavaScript development. | ||
|
|
||
| The plugin uses the [npm](https://www.npmjs.com/) or [Yarn](https://yarnpkg.com/) package manager |
There was a problem hiding this comment.
"uses ... to download ... and can build" can be a bit confusing.
I'd alter the sentence structure to be more uniform, for example: "The plugin downloads dependencies using ... and builds JavaScript bundles from Kotlin projects using ..."
zamulla
reviewed
May 22, 2024
docs/topics/js/js-project-setup.md
Outdated
| It works out of the box without additional configuration, but you can [tune it to specific needs](#yarn). | ||
|
|
||
| You can also use [npm](https://www.npmjs.com/) as your package manager instead. This makes the overall setup of your | ||
| project easier, as you have one less tool to manage. To use npm as your package manager, in your `gradle.properties` |
There was a problem hiding this comment.
From context, it's not evident to me why npm is easier and how there is one less tool to manage if we use one package manager instead of the other. Can we summarize the reasoning here?
ilgonmic
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.