-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document kapt inheritance of super configurations #4206
Conversation
d35b044
to
be6f58f
Compare
b0d91ab
to
a531d2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I left a couple of comments that might be helpful for polish.
You can define a common set of annotation processors in a separate Gradle configuration as a | ||
super configuration and extend it further in kapt-specific configurations for your subprojects. | ||
|
||
As an example, for a subproject using [Dagger](https://dagger.dev/), in your `build.gradle(.kts)` file, use the following configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an example, for a subproject using [Dagger](https://dagger.dev/), in your `build.gradle(.kts)` file, use the following configuration: | |
As an example, for a subproject using [Dagger](https://dagger.dev/), use the following configuration in your `build.gradle(.kts)` file: |
Trying to make it sound a bit smoother, tell me if I succeeded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During my TWr training it was drilled into me that when giving instructions, you always put the WHERE before the WHAT 😄 Is it much harder for you to read if I keep it like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not much harder, but I did stumble over the third comma here :) not a big deal for sure.
74294ba
to
68da1a6
Compare
68da1a6
to
f18bbc9
Compare
This PR documents how kapt configurations can inherit annotation processors from super configurations in Kotlin 2.0.0.