Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Improve Sample Code #4183

Merged
merged 2 commits into from
May 29, 2024
Merged

Docs: Improve Sample Code #4183

merged 2 commits into from
May 29, 2024

Conversation

Attacktive
Copy link
Contributor

  • renamed the local variables:
    name b was used as the constructor parameter AND a local variable.
  • removed val from the constructor parameter
    Screenshot 2024-05-10 11:32:48

@Attacktive Attacktive requested a review from a team as a code owner May 10, 2024 02:54
@AlejandraPedroza AlejandraPedroza self-assigned this May 21, 2024
AlejandraPedroza
AlejandraPedroza approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@AlejandraPedroza AlejandraPedroza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches! Thanks for your contribution.

@AlejandraPedroza AlejandraPedroza merged commit 539d4aa into JetBrains:master May 29, 2024
3 checks passed
@Attacktive Attacktive deleted the docs/rename-local-variables branch May 29, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandraPedroza AlejandraPedroza AlejandraPedroza approved these changes

Assignees

@AlejandraPedroza AlejandraPedroza

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Attacktive @AlejandraPedroza