XML resource optimizations #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid slow XML parsing
…pare resources task
pjBooms
reviewed
Apr 2, 2024
| } | ||
| } | ||
|
|
||
| override suspend fun readPart(path: String, offset: Long, size: Long): ByteArray { |
There was a problem hiding this comment.
Do we read the whole file on web on each string resource? I would cache byte array by path then
| .map { it.nodeName to it.attributes.getNamedItem("name").nodeValue } | ||
| private fun getValueResourceItems(dataFile: File, qualifiers: List<String>, path: Path) : List<ResourceItem> { | ||
| val result = mutableListOf<ResourceItem>() | ||
| RandomAccessFile(dataFile, "r").use { f -> |
There was a problem hiding this comment.
Simple BufferedReader(FileReader) can be used here as you don't use random access in fact (you could use for file positions instead of calculating offsets manually).
pjBooms
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users noticed if an app has big a
string.xmlfile it affects the app startup time: #4537The problem is slow XML parsing.
Possible ways for optimization:
We selected the second way because texts injected to source code have several problems:
Things was done in the PR:
valuesdirectoryRes.arrayaccessor for string-array resourcesvalues*/*.xmlfiles. There will be convertedvalues*/*.cvrfiles.compose.resources.always.generate.accessorswas deleted. It was for internal needs only.Fixes #4537